fix(upnp): add exponential backoff for failed port mappings #6128
+116
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
RolandSherwin
force-pushed
the
upnp_limit_failed_retries
branch
from
d6569d8 to
fc36065
Compare
jxs
approved these changes
Aug 22, 2025
RolandSherwin
force-pushed
the
upnp_limit_failed_retries
branch
from
fc36065 to
2608566
Compare
ackintosh
reviewed
Aug 30, 2025
RolandSherwin
force-pushed
the
upnp_limit_failed_retries
branch
from
2608566 to
ecc1153
Compare
jxs
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit aims to fix an infinite retry loop of failed mappings. We now have an exponential backoff and would retry any failed mappings upto 5 times before giving up.
Change checklist