chore(memory-connection-limits): fix tests #6134
Conversation
jxs
changed the title
There was a problem hiding this comment.
I don't think that we should change the behavior here.
max_allowed_bytes strongly implies that the set number is still allowed; it's the same also e.g. when setting a max_* in ConnectionLimits.
We could instead simply change the docs to
/// New inbound and outbound connections will be denied when the threshold is exceeded.
jxs
force-pushed
the
fix-connection-memory-limits
branch
from
3f1f46b to
e2fbcc2
Compare
There was a problem hiding this comment.
I don't think that we should change the behavior here.
max_allowed_bytes strongly implies that the set number is still allowed; it's the same also e.g. when setting a max_* in ConnectionLimits.We could instead simply change the docs to
/// New inbound and outbound connections will be denied when the threshold is exceeded.
My rational was to give users what they had already been expecting from the doc, but yeah you are right, I missed the max_ and the fact that updating the doc is easier than updating the code.
Thanks Elena
jxs
changed the title
…bp2p into fix-connection-memory-limits
jxs
force-pushed
the
fix-connection-memory-limits
branch
from
e2fbcc2 to
bc71415
Compare
Description
while addressing the flakiness of the tests I noticed the memory limit was not accurate according to the documentation, documentation mentions the limit is reached not greater than.
This PR fixes that.
To address the flakiness due to now connections being probably a little bit smaller in memory footprint I gave room for a connection threshold in the tests.