Skip to content

test: improve get_record_many test coverage with randomization #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: improve get_record_many test coverage with randomization #6163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions protocols/kad/src/behaviour/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,13 +879,13 @@ fn get_record() {

#[test]
fn get_record_many() {
// TODO: Randomise
let num_nodes = 12;
let mut swarms = build_connected_nodes(num_nodes, 3)
.into_iter()
.map(|(_addr, swarm)| swarm)
.collect::<Vec<_>>();
let num_results = 10;
fn run(rng: &mut impl Rng) {
let num_nodes = rng.gen_range(3..20);
let mut swarms = build_connected_nodes(num_nodes, 3)
.into_iter()
.map(|(_addr, swarm)| swarm)
.collect::<Vec<_>>();
let num_results = rng.gen_range(1..num_nodes);

let record = Record::new(random_multihash(), vec![4, 5, 6]);

Expand Down Expand Up @@ -931,6 +931,12 @@ fn get_record_many() {
}
Poll::Pending
}))
}

let mut rng = thread_rng();
for _ in 0..10 {
run(&mut rng)
}
}

/// A node joining a fully connected network via three (ALPHA_VALUE) bootnodes
Expand Down
Loading