Skip to content

Disallow empty Rendezvous namespace to prevent ambiguous Cookie encoding #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disallow empty Rendezvous namespace to prevent ambiguous Cookie encoding #6166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions protocols/rendezvous/src/codec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ impl Namespace {
/// are enforcing a `static lifetime which means this value can only be a constant in the
/// program and hence we hope the developer checked that it is of an acceptable length.
pub fn from_static(value: &'static str) -> Self {
// Empty namespaces are ambiguous on the wire encoding (would be indistinguishable from
// `None`). Disallow empty values to avoid semantic collisions.
if value.is_empty() {
panic!("Namespace must not be empty");
}
if value.len() > crate::MAX_NAMESPACE {
panic!("Namespace '{value}' is too long!")
}
Expand All @@ -67,6 +72,11 @@ impl Namespace {
}

pub fn new(value: String) -> Result<Self, NamespaceTooLong> {
// Empty namespaces are ambiguous on the wire encoding (would be indistinguishable from
// `None`). Disallow empty values to avoid semantic collisions.
if value.is_empty() {
return Err(NamespaceTooLong);
}
if value.len() > crate::MAX_NAMESPACE {
return Err(NamespaceTooLong);
}
Expand Down
Loading