fix(autonat::v2::client): DialBackError visibility
#6168
+12
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusc93
reviewed
Sep 26, 2025
Comment on lines
-377
to
-391
| pub struct Error { | ||
| pub(crate) inner: dial_request::DialBackError, | ||
| } | ||
|
|
||
| impl Display for Error { | ||
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | ||
| Display::fmt(&self.inner, f) | ||
| } | ||
| } | ||
|
|
||
| impl Debug for Error { | ||
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | ||
| Debug::fmt(&self.inner, f) | ||
| } | ||
| } |
There was a problem hiding this comment.
Wouldnt it be better to leave this in place but implement Error (or maybe use thiserror::Error and use #[error(transparent)]) so you can downcast to DialBackError?
There was a problem hiding this comment.
I honestly gave that a small thought initially. I definitely like the second approach more. But I fail to identify a benefit from that layer of indirection, so came with this approach; do you have some on your mind? Like IIRC the idea of thiserror is that someone downstream who uses it can wrap this easily for their needs, and we don't imply it on those who don't want to use it. 😆
Co-authored-by: Darius Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix visibility so downstream could differentiate between
NoConnectionandStreamFailed.Notes & open questions
I guess this one doesn't need adding a test, but if you suggest a good one that would be interesting. Though I can imagine you'd like to add this somewhere in the integration tests on the whole
libp2plevel in a separate issue.Change checklist