Skip to content

Conversation

skaunov
Copy link
Contributor

@skaunov skaunov commented Oct 6, 2025

Description

The change is about allowing putting Record with publisher: None sacrificing republishing.

Sorry for so many lateral changes: I had to delve deeper to understand that the change would actually work and during active reading was eliminating redundant pieces which confuse comprehension with misleading supposition (looking for further use of a variable when it is actually just a parameter/argument was most common impediment).

Notes & open questions

I don't have a fine test for this in mind as it doesn't really do anything (because replication context doesn't yield an event). Simultaneously I'm not really satisfied with the approach I took to adapt/fix the test (retaining only Record with publisher: Some); but I need a hint if that's possible to do better due to the same fact of how silent replication is.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@skaunov skaunov changed the title kad[feat]: enable putting Record without publisher kad: enable putting Record without publisher Oct 6, 2025
@skaunov skaunov changed the title kad: enable putting Record without publisher kad(feat): enable putting Record without publisher Oct 6, 2025
@skaunov skaunov changed the title kad(feat): enable putting Record without publisher feat(kad): enable putting Record without publisher Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant