Skip to content

fix(gossipsub): Fix underflow when shuffling peers after prunning. #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Oct 17, 2025
Merged

fix(gossipsub): Fix underflow when shuffling peers after prunning. #6183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf29a7
Correct underflow and prevent mesh exceeding mesh_n_high
AgeManning Oct 17, 2025
3581061
remove mesh fix for subsequent commit
jxs Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions protocols/gossipsub/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
## 0.50.0
- Fix underflow when shuffling peers after prunning.
See [PR 6183](https://github.com/libp2p/rust-libp2p/pull/6183)

- Remove peer penalty for duplicate messages.
See [PR 6112](https://github.com/libp2p/rust-libp2p/pull/6112)

Expand Down
4 changes: 3 additions & 1 deletion protocols/gossipsub/src/behaviour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2228,7 +2228,9 @@ where
score_p1.partial_cmp(&score_p2).unwrap_or(Ordering::Equal)
});
// shuffle everything except the last retain_scores many peers (the best ones)
shuffled[..peers.len() - self.config.retain_scores()].shuffle(&mut rng);
if peers.len() > self.config.retain_scores() {
shuffled[..peers.len() - self.config.retain_scores()].shuffle(&mut rng);
}

// count total number of outbound peers
let mut outbound = shuffled
Expand Down