Skip to content

Conversation

@momoshell
Copy link
Contributor

Description

From #2217.
Renaming UDS Config symbol from UdsConfig in the doc comment and from TokioUdsConfig, for better referencing when re-exported.
Left deprecated alias for backward compatibility.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momoshell can you revert the clippy and rust doc fixes please? So that we can merge this

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

This pull request has merge conflicts. Could you please resolve them @momoshell? 🙏

@momoshell
Copy link
Contributor Author

momoshell commented Nov 4, 2025

@momoshell can you revert the clippy and rust doc fixes please? So that we can merge this

@jxs Sure thing. I was trying to fix those CI issues before I noticed you guys opened the issue and your PR was being submitted.

@momoshell momoshell force-pushed the uds-consistent-naming branch from d163836 to f960788 Compare November 5, 2025 17:18
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label Nov 6, 2025
@mergify mergify bot added the queued label Nov 6, 2025
@mergify mergify bot merged commit c89444f into libp2p:master Nov 6, 2025
69 of 70 checks passed
@mergify mergify bot removed the queued label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants