-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(uds): Renamed UDS Confing to follow re-export convention #6190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elenaf9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
jxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@momoshell can you revert the clippy and rust doc fixes please? So that we can merge this
|
This pull request has merge conflicts. Could you please resolve them @momoshell? 🙏 |
@jxs Sure thing. I was trying to fix those CI issues before I noticed you guys opened the issue and your PR was being submitted. |
d163836 to
f960788
Compare
jxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
From #2217.
Renaming UDS Config symbol from
UdsConfigin the doc comment and fromTokioUdsConfig, for better referencing when re-exported.Left deprecated alias for backward compatibility.
Notes & open questions
Change checklist