Skip to content

refactor(gossipsub): do early return in for an empty input #6208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Nov 18, 2025
+8 −1
Merged

refactor(gossipsub): do early return in for an empty input #6208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f34d69
gossipsub: do early return in for an empty input
onur-ozkan Nov 17, 2025
c967ca5
add changelog entry
onur-ozkan Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion protocols/gossipsub/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,16 @@

- Fix incorrect default values in ConfigBuilder
See [PR 6113](https://github.com/libp2p/rust-libp2p/pull/6113)

- Remove duplicated config `set_topic_max_transmit_size` method, prefer `max_transmit_size_for_topic`.
See [PR 6173](https://github.com/libp2p/rust-libp2p/pull/6173).

- Switch the internal `async-channel` used to dispatch messages from `NetworkBehaviour` to the `ConnectionHandler`
with an internal priority queue. See [PR 6175](https://github.com/libp2p/rust-libp2p/pull/6175)

- gossipsub: do early return in for an empty input
See [PR 6208](https://github.com/libp2p/rust-libp2p/pull/6208).

## 0.49.2

- Relax `Behaviour::with_metrics` requirements, do not require DataTransform and TopicSubscriptionFilter to also impl Default
Expand Down
4 changes: 4 additions & 0 deletions protocols/gossipsub/src/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ impl Queue {
/// Remove pending low priority Publish and Forward messages.
/// Returns the number of messages removed.
pub(crate) fn remove_data_messages(&mut self, message_ids: &[MessageId]) -> usize {
if message_ids.is_empty() {
return 0;
}

let mut count = 0;
self.non_priority.retain(|message| match message {
RpcOut::Publish { message_id, .. } | RpcOut::Forward { message_id, .. } => {
Expand Down
Loading