feat(relay): remove deprecated error events in favor of warn! logs #6248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the following deprecated relay server events and log them internally at warn level instead: - ReservationReqAcceptFailed - ReservationReqDenyFailed - CircuitReqDenyFailed - CircuitReqAcceptFailed - CircuitReqOutboundConnectFailed These events represent protocol violations or connection failures that don't require programmatic handling. Logging them at warn level allows relay operators to monitor for potential issues without cluttering the event API. Closes libp2p#4757
Author
|
@thomaseizinger Happy to address any feedback or make adjustments. Let me know if you'd like me to change anything! |
Contributor
I no longer maintain this, will delegate to @jxs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4757
This PR removes the deprecated relay server events and replaces them with
tracing::warn!logs:ReservationReqAcceptFailedReservationReqDenyFailedCircuitReqDenyFailedCircuitReqAcceptFailedCircuitReqOutboundConnectFailedChanges
Eventvariants fromrelay::Eventtracing::warn!logs including peer IDs and error detailslibp2p-metricsto remove corresponding event type tracking