Skip to content

chore: update MSRV #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ackintosh wants to merge 8 commits into
base: master
Choose a base branch
from
Open

chore: update MSRV #6273

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
53ecf16
chore: update MSRV from 1.83.0 to 1.88.0
ackintosh Feb 12, 2026
f5d4584
Fix clippy errors
ackintosh Feb 12, 2026
8dd06d5
Update Rust stable version
ackintosh Feb 12, 2026
3205190
Add CHANGELOG entry
ackintosh Feb 12, 2026
a6f2ab8
Update CHANGELOG
ackintosh Feb 12, 2026
fca8552
Update Rust version in Dockerfile
ackintosh Feb 13, 2026
0c25ffb
Bump minor version for all crates due to MSRV change
ackintosh Feb 13, 2026
e05da86
Update workspace dependency versions
ackintosh Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ jobs:
fail-fast: false
matrix:
rust-version: [
1.83.0, # current stable
1.93.1, # current stable
beta,
]
steps:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ members = [
resolver = "2"

[workspace.package]
rust-version = "1.83.0"
rust-version = "1.88.0"
Copy link
Member

@elenaf9 elenaf9 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to bump the version of all our crates because this is a breaking change, right?

Copy link
Member

@dariusc93 dariusc93 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. This would be considered a breaking change so I would suggest bumping the crates to the next version.

Copy link
Member

@jxs jxs Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pff, but yeah let's do it

edition = "2021"

[workspace.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion hole-punching-tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.5-labs
FROM rust:1.83.0 as builder
FROM rust:1.88.0 as builder

# Run with access to the target cache to speed up builds
WORKDIR /workspace
Expand Down
3 changes: 3 additions & 0 deletions libp2p/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
- Fix `metrics` delegation to gossipsub protocol.
See [PR 6180](https://github.com/libp2p/rust-libp2p/pull/6180)

- Raise MSRV to 1.88.0.
See [PR 6273](https://github.com/libp2p/rust-libp2p/pull/6273).

## 0.56.0

- Remove `async-std` support.
Expand Down
2 changes: 1 addition & 1 deletion misc/server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.5-labs
FROM rust:1.83.0 as chef
FROM rust:1.88.0 as chef
RUN wget -q -O- https://github.com/LukeMathWalker/cargo-chef/releases/download/v0.1.62/cargo-chef-x86_64-unknown-linux-gnu.tar.gz | tar -zx -C /usr/local/bin
WORKDIR /app

Expand Down
9 changes: 7 additions & 2 deletions protocols/gossipsub/src/behaviour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,7 +2104,10 @@ where
self.apply_iwant_penalties();

// check connections to explicit peers
if self.heartbeat_ticks % self.config.check_explicit_peers_ticks() == 0 {
if self
.heartbeat_ticks
.is_multiple_of(self.config.check_explicit_peers_ticks())
{
for p in self.explicit_peers.clone() {
self.check_explicit_peer_connection(&p);
}
Expand Down Expand Up @@ -2321,7 +2324,9 @@ where
}

// should we try to improve the mesh with opportunistic grafting?
if self.heartbeat_ticks % self.config.opportunistic_graft_ticks() == 0
if self
.heartbeat_ticks
.is_multiple_of(self.config.opportunistic_graft_ticks())
&& peers.len() > 1
{
if let PeerScoreState::Active(peer_score) = &self.peer_score {
Expand Down
2 changes: 1 addition & 1 deletion protocols/perf/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.5-labs
FROM rust:1.83.0 as builder
FROM rust:1.88.0 as builder

# Run with access to the target cache to speed up builds
WORKDIR /workspace
Expand Down
Loading