Skip to content

fix the --test-ignore calculation #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhuseby merged 1 commit into from
Dec 16, 2025
Merged

fix the --test-ignore calculation #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions .github/workflows/hole-punch-interop-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,38 @@ jobs:
else
# Automatic trigger - use change detection outputs
echo "test-select=${{ steps.detect.outputs.changed-impls }}" >> $GITHUB_OUTPUT
echo "test-ignore=!${{ steps.detect.outputs.changed-impls }}" >> $GITHUB_OUTPUT

# Negate each implementation ID in the pipe-separated list
CHANGED_IMPLS="${{ steps.detect.outputs.changed-impls }}"
if [ -n "$CHANGED_IMPLS" ]; then
NEGATED_IMPLS=$(echo "$CHANGED_IMPLS" | sed 's/|/|!/g;s/^/!/')
echo "test-ignore=$NEGATED_IMPLS" >> $GITHUB_OUTPUT
else
echo "test-ignore=" >> $GITHUB_OUTPUT
fi

echo "relay-select=${{ steps.detect.outputs.changed-relays }}" >> $GITHUB_OUTPUT
echo "relay-ignore=!${{ steps.detect.outputs.changed-relays }}" >> $GITHUB_OUTPUT

# Negate each relay ID in the pipe-separated list
CHANGED_RELAYS="${{ steps.detect.outputs.changed-relays }}"
if [ -n "$CHANGED_RELAYS" ]; then
NEGATED_RELAYS=$(echo "$CHANGED_RELAYS" | sed 's/|/|!/g;s/^/!/')
echo "relay-ignore=$NEGATED_RELAYS" >> $GITHUB_OUTPUT
else
echo "relay-ignore=" >> $GITHUB_OUTPUT
fi

echo "router-select=${{ steps.detect.outputs.changed-routers }}" >> $GITHUB_OUTPUT
echo "router-ignore=!${{ steps.detect.outputs.changed-routers }}" >> $GITHUB_OUTPUT

# Negate each router ID in the pipe-separated list
CHANGED_ROUTERS="${{ steps.detect.outputs.changed-routers }}"
if [ -n "$CHANGED_ROUTERS" ]; then
NEGATED_ROUTERS=$(echo "$CHANGED_ROUTERS" | sed 's/|/|!/g;s/^/!/')
echo "router-ignore=$NEGATED_ROUTERS" >> $GITHUB_OUTPUT
else
echo "router-ignore=" >> $GITHUB_OUTPUT
fi

echo "force-matrix-rebuild=${{ steps.detect.outputs.impls-yaml-changed }}" >> $GITHUB_OUTPUT
echo "force-image-rebuild=${{ steps.detect.outputs.impls-folder-changed }}" >> $GITHUB_OUTPUT
echo "debug=false" >> $GITHUB_OUTPUT
Expand Down
22 changes: 20 additions & 2 deletions .github/workflows/perf-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,27 @@ jobs:
else
# Automatic trigger - use change detection outputs
echo "test-select=${{ steps.detect.outputs.changed-impls }}" >> $GITHUB_OUTPUT
echo "test-ignore=!${{ steps.detect.outputs.changed-impls }}" >> $GITHUB_OUTPUT

# Negate each implementation ID in the pipe-separated list
CHANGED_IMPLS="${{ steps.detect.outputs.changed-impls }}"
if [ -n "$CHANGED_IMPLS" ]; then
NEGATED_IMPLS=$(echo "$CHANGED_IMPLS" | sed 's/|/|!/g;s/^/!/')
echo "test-ignore=$NEGATED_IMPLS" >> $GITHUB_OUTPUT
else
echo "test-ignore=" >> $GITHUB_OUTPUT
fi

echo "baseline-select=${{ steps.detect.outputs.changed-baselines }}" >> $GITHUB_OUTPUT
echo "baseline-ignore=!${{ steps.detect.outputs.changed-baselines }}" >> $GITHUB_OUTPUT

# Negate each baseline ID in the pipe-separated list
CHANGED_BASELINES="${{ steps.detect.outputs.changed-baselines }}"
if [ -n "$CHANGED_BASELINES" ]; then
NEGATED_BASELINES=$(echo "$CHANGED_BASELINES" | sed 's/|/|!/g;s/^/!/')
echo "baseline-ignore=$NEGATED_BASELINES" >> $GITHUB_OUTPUT
else
echo "baseline-ignore=" >> $GITHUB_OUTPUT
fi

echo "iterations=10" >> $GITHUB_OUTPUT
echo "force-matrix-rebuild=${{ steps.detect.outputs.impls-yaml-changed }}" >> $GITHUB_OUTPUT
# Force image rebuild if impls.yaml changed (commit SHA changes require new images)
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/transport-interop-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,16 @@ jobs:
else
# Automatic trigger - use change detection outputs
echo "test-select=${{ steps.detect.outputs.changed-impls }}" >> $GITHUB_OUTPUT
echo "test-ignore=!${{ steps.detect.outputs.changed-impls }}" >> $GITHUB_OUTPUT

# Negate each implementation ID in the pipe-separated list
CHANGED_IMPLS="${{ steps.detect.outputs.changed-impls }}"
if [ -n "$CHANGED_IMPLS" ]; then
NEGATED_IMPLS=$(echo "$CHANGED_IMPLS" | sed 's/|/|!/g;s/^/!/')
echo "test-ignore=$NEGATED_IMPLS" >> $GITHUB_OUTPUT
else
echo "test-ignore=" >> $GITHUB_OUTPUT
fi

echo "force-matrix-rebuild=${{ steps.detect.outputs.impls-yaml-changed }}" >> $GITHUB_OUTPUT
# Force image rebuild if impls.yaml changed (commit SHA changes require new images)
# or if impls folder changed (local implementation files changed)
Expand Down