Skip to content

add zig commit hash#54

Open
bomanaps wants to merge 2 commits intolibp2p:masterfrom
bomanaps:update/commit
Open

add zig commit hash#54
bomanaps wants to merge 2 commits intolibp2p:masterfrom
bomanaps:update/commit

Conversation

@bomanaps
Copy link
Copy Markdown
Collaborator

@bomanaps bomanaps commented Mar 2, 2026

update zig commit hash

@bomanaps bomanaps requested a review from dhuseby as a code owner March 2, 2026 18:00
@dhuseby
Copy link
Copy Markdown
Contributor

dhuseby commented Mar 4, 2026

@bomanaps

I'm seeing a "missing required env var transport" error in the log file.

Listener:

 Container eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener Starting 
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env HOME=/root
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env HOSTNAME=20db9373df4f
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env DEBUG=false
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env TRANSPORT=quic-v1
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env LISTENER_IP=0.0.0.0
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env IS_DIALER=false
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env REDIS_ADDR=transport-redis:6379
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env TEST_KEY=39a1ecbd
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | error: missing required env var transport
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | error: EnvironmentVariableNotFound

Dialer:

 Container eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer Stopping 
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env HOME=/root
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env HOSTNAME=836c2723040c
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env DEBUG=false
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env TRANSPORT=quic-v1
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env LISTENER_IP=0.0.0.0
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env IS_DIALER=true
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env REDIS_ADDR=transport-redis:6379
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env TEST_KEY=39a1ecbd
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | error: missing required env var transport
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | error: EnvironmentVariableNotFound

Will you patch the test application to fix this? You can either add a patch file like the way the rust-v0.56 test application is patched in this repo, or submit a PR to the eth-p2p-z repo. Patching it in this repo first and then upstreaming the patch is the preferred approach.

🍻

dhuseby
dhuseby requested changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhuseby dhuseby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the env variable error in the test application.

@bomanaps
Copy link
Copy Markdown
Collaborator Author

bomanaps commented Mar 4, 2026

Please fix the env variable error in the test application.

Okay, I will do that

@bomanaps bomanaps mentioned this pull request Mar 4, 2026
Merged
@bomanaps
Copy link
Copy Markdown
Collaborator Author

bomanaps commented Mar 4, 2026

@bomanaps

I'm seeing a "missing required env var transport" error in the log file.

Listener:

 Container eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener Starting 
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env HOME=/root
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env HOSTNAME=20db9373df4f
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env DEBUG=false
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env TRANSPORT=quic-v1
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env LISTENER_IP=0.0.0.0
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env IS_DIALER=false
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env REDIS_ADDR=transport-redis:6379
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | info: env TEST_KEY=39a1ecbd
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | error: missing required env var transport
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__listener  | error: EnvironmentVariableNotFound

Dialer:

 Container eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer Stopping 
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env HOME=/root
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env HOSTNAME=836c2723040c
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env DEBUG=false
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env TRANSPORT=quic-v1
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env LISTENER_IP=0.0.0.0
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env IS_DIALER=true
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env REDIS_ADDR=transport-redis:6379
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | info: env TEST_KEY=39a1ecbd
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | error: missing required env var transport
eth-p2p-z-v0_0_1_x_eth-p2p-z-v0_0_1__quic-v1__dialer    | error: EnvironmentVariableNotFound

Will you patch the test application to fix this? You can either add a patch file like the way the rust-v0.56 test application is patched in this repo, or submit a PR to the eth-p2p-z repo. Patching it in this repo first and then upstreaming the patch is the preferred approach.

🍻

I have made a PR for it here zen-eth/eth-p2p-z#115. Sorry, I was unable to properly test this as I had a macOS Docker compatibility issue which I couldn't resolve.

@dhuseby
Copy link
Copy Markdown
Contributor

dhuseby commented Mar 5, 2026

it looks like your PR zen-eth/eth-p2p-z#115 has been landed. will you update this PR with the latest commit hash so that it picks up the changes?

I'm also curious about your macOS Docker compatibility issues. What are you seeing? What do you think the problem is?

@bomanaps
Copy link
Copy Markdown
Collaborator Author

bomanaps commented Mar 5, 2026

it looks like your PR zen-eth/eth-p2p-z#115 has been landed. will you update this PR with the latest commit hash so that it picks up the changes?

I'm also curious about your macOS Docker compatibility issues. What are you seeing? What do you think the problem is?

Mac ARM64 Docker uses QEMU emulation for Linux x86_64 containers so this causes zig build failures which points to invalid CPU detection and stdlib bugs, but native Ubuntu (CI) works fine.

@dhuseby
Copy link
Copy Markdown
Contributor

dhuseby commented Mar 6, 2026

ah interesting.

@dhuseby
Copy link
Copy Markdown
Contributor

dhuseby commented Mar 9, 2026

any progress?

@bomanaps
Copy link
Copy Markdown
Collaborator Author

bomanaps commented Mar 10, 2026

any progress?

Yes, updated the commit hash now includes the fix from zen-eth/eth-p2p-z#115. Ready for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhuseby dhuseby dhuseby requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bomanaps @dhuseby