Increase maxfun for cobyla#45
Merged
amontoison merged 1 commit intolibprima:mainfrom Jul 14, 2025
andreasnoack:an/iterations
Merged
Increase maxfun for cobyla#45amontoison merged 1 commit intolibprima:mainfrom andreasnoack:an/iterations
amontoison merged 1 commit intolibprima:mainfrom
andreasnoack:an/iterations
Conversation
And make maxfun conditional on the solver since cobyla needs many more function evaluations than the other solvers.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 87.50% 85.66% -1.84%
==========================================
Files 4 4
Lines 320 300 -20
==========================================
- Hits 280 257 -23
- Misses 40 43 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontoison
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make maxfun conditional on the solver since cobyla needs many more function evaluations than the other solvers.
The current failures on macos and arm are because the COBYLA fits slightly exceed the number of allowed function evaluations (6000). I guess slight rounding differences could cause COBYLA to take some extra and costly steps.
Closes #34