Skip to content

Increase maxfun for cobyla#45

Merged
amontoison merged 1 commit intolibprima:mainfrom
andreasnoack:an/iterations
Jul 14, 2025
Merged

Increase maxfun for cobyla#45
amontoison merged 1 commit intolibprima:mainfrom
andreasnoack:an/iterations

Conversation

@andreasnoack
Copy link
Contributor

@andreasnoack andreasnoack commented Jul 14, 2025

And make maxfun conditional on the solver since cobyla needs many more function evaluations than the other solvers.

The current failures on macos and arm are because the COBYLA fits slightly exceed the number of allowed function evaluations (6000). I guess slight rounding differences could cause COBYLA to take some extra and costly steps.

Closes #34

And make maxfun conditional on the solver since cobyla needs many
more function evaluations than the other solvers.
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (6bc54d7) to head (cd37f02).
Report is 23 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   87.50%   85.66%   -1.84%     
==========================================
  Files           4        4              
  Lines         320      300      -20     
==========================================
- Hits          280      257      -23     
- Misses         40       43       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison amontoison merged commit af79578 into libprima:main Jul 14, 2025
14 of 15 checks passed
@andreasnoack andreasnoack deleted the an/iterations branch July 14, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests on macOS

3 participants