feat(lexer): Support skipping over MACROs#121
Merged
6d7a merged 2 commits intolibrasn:mainfrom Jun 24, 2025
Merged
Conversation
6d7a
requested changes
Jun 23, 2025
Member
6d7a
left a comment
6d7a
left a comment
There was a problem hiding this comment.
Thank you for the quick follow-up! Just two requests:
Double quote are escaped by a pair of double quotes.
Parse the MACRO so that it can be skipped over. A warning about missing support is emitted.
Contributor
Author
|
Thanks for the suggestions. They should now be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse top level MACRO definitions.
Currently only used to skip over MACROs, and to emit a warning about missing support.