Use a tri-state for InformationObjectClassField optionality#128
Merged
6d7a merged 1 commit intolibrasn:mainfrom Jun 30, 2025
Merged
Use a tri-state for InformationObjectClassField optionality#1286d7a merged 1 commit intolibrasn:mainfrom
6d7a merged 1 commit intolibrasn:mainfrom
Conversation
Information object class fields can be either OPTIONAL, DEFAULT or required. Model it with an enum of these three states. This makes the invalid state where `is_optional == true` and `default` is `Some(..)` unrepresentable. This also makes the default value generic, which will be required to parse different types of default values in the future.
Rawk
force-pushed
the
class-field-optionality
branch
from
4d14fec to
08f460d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information object class fields can be either OPTIONAL, DEFAULT or required. Model it with an enum of these three states.
This makes the invalid state where
is_optional == trueanddefaultisSome(..)unrepresentable.This also makes the default value generic, which will be required to parse different types of default values in the future.