Closed
Conversation
6d7a
reviewed
Nov 27, 2025
Member
6d7a
left a comment
6d7a
left a comment
There was a problem hiding this comment.
Looks good, just one question concerning the removed match arms.
Rawk
force-pushed
the
reserved-char-seq
branch
from
f12c6e1 to
8278b85
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Rawk
force-pushed
the
reserved-char-seq
branch
from
8278b85 to
382fd69
Compare
Contributor
Author
Rawk
force-pushed
the
reserved-char-seq
branch
from
382fd69 to
2e9dedd
Compare
Contributor
Author
|
Fixed the merge conflicts. |
Rawk
force-pushed
the
reserved-char-seq
branch
from
2e9dedd to
c0c82d5
Compare
Contributor
Author
|
Fixed the merge conflicts. |
For example, split "SEQUENCE OF" into it's two reserved character sequences "SEQUENCE" and "OF". This is to better follow the reserved words, and also allows white space between words.
Rawk
force-pushed
the
reserved-char-seq
branch
from
c0c82d5 to
64bba7e
Compare
Contributor
Author
|
I have moved most of these changes into smaller pull requests that hopefully is easier to review. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(parser): Split up combined reserved words
For example, split "SEQUENCE OF" into it's two reserved character sequences "SEQUENCE" and "OF". This is to better follow the reserved words, and also allows arbitrary white space between words.