Skip to content

Comments

Improve en-/decode error messages#536

Merged
XAMPPRocky merged 2 commits intolibrasn:mainfrom
decryphe:topic/improve-en-de-code-error-messages
Feb 20, 2026
Merged

Improve en-/decode error messages#536
XAMPPRocky merged 2 commits intolibrasn:mainfrom
decryphe:topic/improve-en-de-code-error-messages

Conversation

@decryphe
Copy link
Contributor

@decryphe decryphe commented Feb 3, 2026

With this PR the goal was to improve two things:

  • Make wrapped codec-specific errors display their contents, making them presentable to an application user.
    • In the application we're writing, we would like to expose this information via an API to make it easier for an API-user to figure out why a given payload gets rejected.
  • Harmonize the other error messages a bit, mainly consistent punctuation, capitalization, removing a single newline and some minor grammar.
    • I tried to be pretty unintrusive with the changes to not change the original authors' intentions (and I would have to read up way more on error usage to do a better job).

Looking forward to feedback/ideas and am willing to do further improvements on error messages if that is of value to the project.

Tested with just all, should be good.

@decryphe
Copy link
Contributor Author

Is there anything else that needs to be done? I see the CI pipeline is failing.

@decryphe decryphe requested a review from XAMPPRocky February 17, 2026 15:07
@decryphe
Copy link
Contributor Author

The checks now passed on my branch as part of the PR source: https://github.com/decryphe/rasn/actions/runs/22103158594

@XAMPPRocky
Copy link
Collaborator

Thank you for your PR! I believe you need to rebase onto main and then the CI and conflicts should be resolved and we can merged.

@decryphe decryphe force-pushed the topic/improve-en-de-code-error-messages branch from a1d5e0b to 567c343 Compare February 20, 2026 12:16
@decryphe
Copy link
Contributor Author

Yes, that was it. I hadn't seen that you bumped to edition 2024 in the meantime.

@XAMPPRocky XAMPPRocky merged commit 40ef391 into librasn:main Feb 20, 2026
44 checks passed
This was referenced Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants