Improve en-/decode error messages#536
Merged
XAMPPRocky merged 2 commits intolibrasn:mainfrom Feb 20, 2026
Merged
Conversation
XAMPPRocky
approved these changes
Feb 3, 2026
Contributor
Author
|
Is there anything else that needs to be done? I see the CI pipeline is failing. |
Contributor
Author
|
The checks now passed on my branch as part of the PR source: https://github.com/decryphe/rasn/actions/runs/22103158594 |
Collaborator
|
Thank you for your PR! I believe you need to rebase onto main and then the CI and conflicts should be resolved and we can merged. |
a1d5e0b to
567c343
Compare
Contributor
Author
|
Yes, that was it. I hadn't seen that you bumped to edition 2024 in the meantime. |
This was referenced Feb 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR the goal was to improve two things:
Looking forward to feedback/ideas and am willing to do further improvements on error messages if that is of value to the project.
Tested with
just all, should be good.