chore(rustc): bump workspace to rust 2024 edition#539
Merged
XAMPPRocky merged 11 commits intolibrasn:mainfrom Feb 19, 2026
Merged
chore(rustc): bump workspace to rust 2024 edition#539XAMPPRocky merged 11 commits intolibrasn:mainfrom
XAMPPRocky merged 11 commits intolibrasn:mainfrom
Conversation
…arning in macro
mkatychev
commented
Feb 18, 2026
Comment on lines
+543
to
+550
| // Use shorthand syntax for named fields; unnamed fields use full form | ||
| if let Some(field_ident) = field.ident.as_ref() { | ||
| (quote!(#field_ident), quote!(#field_ident)) | ||
| } else { | ||
| let index = syn::Index::from(i); | ||
| let ident = format_ident!("i{}", index); | ||
| (quote!(#index: #ident), quote!(#index: #ident)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Previous approach triggered https://doc.rust-lang.org/stable/nightly-rustc/rustc_lint/builtin/static.NON_SHORTHAND_FIELD_PATTERNS.html
when using (quote!(#name : ref #ident), quote!(#name : #ident)) in places such as
Lines 71 to 73 in 6c25ecb
happy to revert and make it an allow(
mkatychev
commented
Feb 18, 2026
| impl TypeExt for syn::Type { | ||
| fn strip_lifetimes(&mut self) { | ||
| if let syn::Type::Reference(ref mut reference) = self { | ||
| if let syn::Type::Reference(reference) = self { |
Contributor
Author
There was a problem hiding this comment.
This was triggering cannot explicitly borrow within an implicitly-borrowing pattern in here:
rasn/standards/pkix/src/lib.rs
Lines 460 to 468 in 7697031
XAMPPRocky
approved these changes
Feb 19, 2026
Collaborator
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
This was referenced Jan 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran:
cargo clippy --fix --workspacecargo fmtFixed a few clippy warnings originating in rasn-derive