Conversation
nicopace
left a comment
There was a problem hiding this comment.
Also, in the document a lot of times the word "governance" is used, but it is not clear what it means.
Is there any REST API documentation to refer to? maybe would be good to add a link so the review can be done with more info.
|
@nicopace Thanks for the review, have updated the code 👍
Please check this PR on Pirania repo. |
|
Just waiting for the lime-packages pirania PR to come thru? |
|
Hi @luandro , there are a number of changes necessary so that it can be merged. It would also be nice to tell the storybook of the screens and components. It really helps to avoid bugs, and to review the code without having to have a router nearby. |
|
I just saw that the first thing you already did three days ago :) |
gmarcos87
left a comment
There was a problem hiding this comment.
Can you undo the merge and do with overflow? The history of git is quite contaminated and difficult to read when the merge is done.
|
@gmarcos87 running storybook here causes an error: Undo what merge? I don't know what's overflow, is that on git? |
Ready for review
Implementing Pirania admin into LiMe-App.