Skip to content

Add Pirania admin#218

Closed
luandro wants to merge 44 commits intodevelopfrom
pirania
Closed

Add Pirania admin#218
luandro wants to merge 44 commits intodevelopfrom
pirania

Conversation

@luandro
Copy link
Contributor

@luandro luandro commented Dec 29, 2019

Ready for review

Implementing Pirania admin into LiMe-App.

@luandro luandro requested a review from gmarcos87 December 29, 2019 14:27
Copy link
Contributor

@nicopace nicopace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, in the document a lot of times the word "governance" is used, but it is not clear what it means.
Is there any REST API documentation to refer to? maybe would be good to add a link so the review can be done with more info.

@nicopace nicopace self-requested a review December 30, 2019 15:54
@luandro
Copy link
Contributor Author

luandro commented Jan 1, 2020

@nicopace Thanks for the review, have updated the code 👍

Also, in the document a lot of times the word "governance" is used, but it is not clear what it means.
Is there any REST API documentation to refer to? maybe would be good to add a link so the review can be done with more info.

Please check this PR on Pirania repo.

@luandro luandro changed the title WIP: Add Pirania admin Add Pirania admin Jan 5, 2020
@luandro luandro requested a review from nicopace February 14, 2020 18:58
@luandro
Copy link
Contributor Author

luandro commented Feb 14, 2020

Just waiting for the lime-packages pirania PR to come thru?

@gmarcos87
Copy link
Contributor

Hi @luandro , there are a number of changes necessary so that it can be merged.
First update the epics so that they work with the new version of redux-observables. You can see the changes in the other epics in this commit (8500cc5)

It would also be nice to tell the storybook of the screens and components. It really helps to avoid bugs, and to review the code without having to have a router nearby.

@gmarcos87
Copy link
Contributor

I just saw that the first thing you already did three days ago :)

Copy link
Contributor

@gmarcos87 gmarcos87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the merge and do with overflow? The history of git is quite contaminated and difficult to read when the merge is done.

@luandro
Copy link
Contributor Author

luandro commented Feb 17, 2020

@gmarcos87 running storybook here causes an error: React is not defined

Undo what merge? I don't know what's overflow, is that on git?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants