Allow external redis and and mysql

[mkuurstra]

Hi,

This PR is for the functionality mentioned in #18. In total I made the following changes:

• Allow external redis and and mysql
• Support for redis authentication when using external installation

Some of these are probably breaking changes but I have this chart running in my own infrastructure since just now and it seems to run fine. My values.yaml:

---
librenms:
  existingSecret: op-librenms
  timezone: Europe/Amsterdam
  poller:
    replicas: 1

ingress:
  enabled: true
  className: traefik
  annotations: {}
  hosts:
    - host: librenms.example.com
      paths:
        - path: /
          pathType: Prefix
  tls:
    - secretName: librenms-tls
      hosts:
        - librenms.example.com

privileged: true

mysql:
  enabled: false
  external:
    host: mariadb.services
    port: 3306
    username: librenms
    database: librenms
    existingSecret: op-librenms
    existingSecretKey: DATABASE_PSW

redis:
  enabled: false
  external:
    host: librenms-redis-master
    port: 6379
    existingSecret: op-librenms
    existingSecretKey: REDIS_PASSWORD

[jacobw]

Thanks for the PR. I've started a review but will need to continue it as time permits.

[jacobw]

Are you able to split this PR in to commits for each part. of the change. I.e. lock file, external redirects and mysql, health checks, mount removals. This is partly to make the review easier but also to make the commit history easy to follow for others.

[mkuurstra]

Sorry, I normally don't use Github so not sure on how to do multiple PR's using forks. I have removed all other changes and I hope that I remember to make new PR's after this one is merged.

[jacobw]

You can submit multiple commits in the PR, they don't have to be separate PRs.

This PR as it is has many commits that would pollute the commit history of the repo if the PR was merged so they need to be cleaned up in advance. if you're really stuck, just create a fresh fork and create some clean commits.

If you get your local repo into a good state you can force push and it will update the PR automatically. I usually use interactive rebases to clean up individual commits on a PR.

[mkuurstra]

Ahh, I misread. I rebased it into a single commit and I'll add commits for the rest

[mkuurstra]

While looking up the changes I found an extra error in case librenms.snmp_scanner.extraEnvs is defined. When defined it causes an invalid YAML.

But I think this is it. The commits look good and precise to me and the configuration works in my environment.

[jacobw]

Thanks - looking much better! I'll continue the review as soon as I can.

[jacobw]

I have created a separate PR that added all of the changed unrelated to the external mysql and redis. I'm open to any PRs to add this now.

[mkuurstra]

I'm sorry, I've no recollection of what I did 3 months ago. I'm not sure what you mean, do you mean you want me to open a new PR containing only the first commit?

553f85d

[einardivision]

Hey guys, Is there any update on this?

[jacobw]

I think his PR needs quite a bit of work. I'm keen to make it happen but haven't had the time yet sorry.

[jacobw]

superseded by #177