Skip to content

Conversation

@photovoltex
Copy link
Member

Fixes the transfer flow handling when the context_uri is empty and the context has no tracks. I'm still not sure how this can happen, but some users seem to have encountered it so this should improve the handling for these specific cases.

Additionally the grayed out play/pause button when transferring was fixed and should now stay enabled during transfering.

Fixes #1566

Copilot AI review requested due to automatic review settings September 13, 2025 19:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the robustness of the transfer flow by handling edge cases where context_uri is empty and the context has no tracks. It addresses user-reported issues where transfers would fail under these conditions.

  • Added fallback handling for empty track contexts during transfers
  • Enhanced error handling for context retrieval failures
  • Updated the initial transfer handler to accept and use the context URI

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
connect/src/state/transfer.rs Updated initial transfer handler to accept context URI parameter and set player context fields
connect/src/spirc.rs Added fallback logic for empty track contexts and improved error handling for context retrieval
CHANGELOG.md Documented the bug fix and reorganized existing entries

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@roderickvd roderickvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also minor questions. Sorry for the long wait for the review!

roderickvd
roderickvd previously approved these changes Nov 7, 2025
Copy link
Member

@roderickvd roderickvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roderickvd roderickvd merged commit d007e3a into librespot-org:dev Nov 7, 2025
11 of 12 checks passed
@photovoltex photovoltex deleted the fix/harden-transfer-flow branch November 7, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librespot Invalid state { the provided context has no tracks }

2 participants