Fix x11 undefined behavior #18323
Open
Fix x11 undefined behavior #18323
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the mouse device list was meant to be initialized with -1, but the mouse device list should contain only up to `j` values where j is the number of actual mice.
This is just to be safe in case we have... more than 16 master pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the mouse device list was meant to be initialized with -1, but the mouse device list should contain only up to
jvalues where j is the number of actual mice. As is, the loop will iterate up to the number of X11 devices, rather than up to the number of possible mice.If someone could review this to make sure I didn't mess anything up I'd appreciate it!