Expect same controler GUID format for SDL2 on Windows as Linux

[bcat]

Description

RA parses the SDL joystick GUID differently for Windows than it does for Linux. However, SDL has used the same GUID format on all platforms for quite some time (since 2.0.5, and RA's currently bundling 2.0.14.0 with its Windows builds).

Since we currently parse the GUID wrong on Windows, without this change, using the SDL2 driver on Windows results in bogus input_vendor_id and input_product_id values:

After this change, the values are correct:

(Notice the fixed sdl2 driver values now match the correct ones reported by the xinput driver.)

Related Issues

Fixes #18634.

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

[cmitu]

I think this PR includes - by mistake probably - your own retroarch.cfg, which overwrites the example commented retroarch.cfg present in the repository.

[sonninnos]

It sure does. Never run RA from the build dir.

[bcat]

D'oh. You're right of course. That's why I shouldn't send PRs late at night....

Will fix this evening, apologies.

[sonninnos]

I renamed the skeleton default cfg to avoid similar confusion in the future. Still weird how it got included in since retroarch.cfg is in .gitignore..

Edit: Sigh, had to revert the rename because packaging scripts fail otherwise.

[bcat]

Removed the retroarch.cfg that snuck in.

Also tested a bit more locally with various different controllers (XInput, DInput, Switch controllers, wired & wireless, etc.), and this seems to have the desired effect for them all.

Side note: Other than this small bug, I'm quite happy with the SDL controller experience overall. The usual XInput and DInput devices work the same as before, and some controllers that reported identical input_device values (8BitDo Ultimate 2 vs Pro 3) in the xinput driver have distinct ones with the sdl2 driver. But the main QoL improvement is that Switch controllers (Pro Controller, N64 controller, etc.) work without issue. (I did drop in a newer SDL DLL since the RetroArch one is a bit old, and there've been some Switch-related fixes upstream since then.)