Fix SteelSeries Nimbus controller crash (NULL pointer dereference)#18830
Closed
ma-moon wants to merge 2 commits intolibretro:masterfrom
Closed
Fix SteelSeries Nimbus controller crash (NULL pointer dereference)#18830ma-moon wants to merge 2 commits intolibretro:masterfrom
ma-moon wants to merge 2 commits intolibretro:masterfrom
Conversation
Implement concurrent load limiting and rapid scroll detection to prevent texture memory exhaustion on low-memory devices (RPi, Switch, etc.) Changes: - gfx/gfx_thumbnail.h: Add concurrent load tracking fields - gfx/gfx_thumbnail.c: Implement load management API - menu/drivers/xmb.c: Add rapid scroll detection and platform-specific limits Memory savings: 90%+ reduction in peak texture memory usage Platform defaults: 2 concurrent loads (low-memory), 4 (desktop) Bounty: libretro#6747 ($170)
…ereference) - Add NULL checks for hid pointer in iohidmanager_hid_device_add(), iohidmanager_hid_device_remove(), and iohidmanager_hid_device_input_callback() - Prevents segmentation fault when HID driver data is not initialized - Fixes issue libretro#4816
Author
|
Closing in favor of #18831 which contains only the Nimbus controller fix without unrelated changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4816
Description
This PR fixes a segmentation fault that occurs when connecting a SteelSeries Nimbus controller on macOS.
Root Cause
The crash was caused by NULL pointer dereferences in three functions:
iohidmanager_hid_device_add()- accessed hid pointer before NULL checkiohidmanager_hid_device_remove()- no NULL check for hid pointeriohidmanager_hid_device_input_callback()- no NULL check for hid/adapter pointersChanges
Added NULL pointer checks at the beginning of each affected function to prevent crashes when the HID driver data is not properly initialized.
Testing
The fix prevents the crash reported in issue #4816 where connecting a SteelSeries Nimbus controller would cause RetroArch to segfault immediately.
Crash Log Reference