XMB: Support all possible image formats for dynamic wallpapers#18868
Open
Ecco wants to merge 1 commit intolibretro:masterfrom
Open
XMB: Support all possible image formats for dynamic wallpapers#18868Ecco wants to merge 1 commit intolibretro:masterfrom
Ecco wants to merge 1 commit intolibretro:masterfrom
Conversation
The png extension was hardcoded, no matter what image format was supported. We now dynamically check for supported image formats and look for the corresponding extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Before this PR, only PNG wallpapers were supported. This was pretty inefficient for two reasons:
In other words, PNGs waste both time and storage.
Description
This pull requests tries to load wallpapers according to the image formats that RetroArch supports. Before this PR, XMB would always try to look up
.pngfiles, even ifHAVE_RPNGwas not set.The behavior is similar to what RetroArch already does for thumbnails, and uses the same priority order: it will first try PNG, then JPEG, then BMP, and finally TGA, and will use whichever image it finds first, if any.