Fix for XMB menu freeze when scan button pushed twice in file explorer#18907
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Apr 7, 2026
Merged
Conversation
Scanning needs to follow up potentially added playlists by an extra menu refresh. When scanning was invoked from file browser under XMB, by pushing retropad-y, second scanning followup would get lost as the logic is brittle, resulting in an unresponsive menu. The extra menu refresh is now combined with the regular scan task.
zoltanvb
force-pushed
the
xmb_double_scan_problem
branch
from
464ec8a to
27325e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scanning needs to follow up potentially added playlists by an extra menu refresh. When scanning was invoked from file browser under XMB, by pushing retropad-y, second scanning followup would get lost as the logic is brittle, resulting in an unresponsive menu.
The extra menu refresh is now combined with the regular scan task.
This also allows a better workflow for cherry picking content file-by-file into a playlist: set up scanning as needed, scan a single file, then instead of always selecting content - going back to scan menu - starting scan - selecting content again, single-button scan can be triggered from the file browser. (This was also possible earlier, just not very much known.)
Related Issues
This was one of the postponed issues in #18641 .
Reviewers
@sonninnos