Skip to content

Conversation

@cscd98
Copy link

@cscd98 cscd98 commented Dec 15, 2025

Set some optional? performance flags.

@notaz
Copy link
Collaborator

notaz commented Dec 15, 2025

HAVE_NEON_ASM is 32-bit only and will break arm64 build, but from quick googling it seems there are arm64 webos devices. Also it should be autodetected anyway, so I think you can just leave it out.

notaz added a commit that referenced this pull request Dec 15, 2025
only results in confusion like in #899
@notaz
Copy link
Collaborator

notaz commented Dec 15, 2025

Turns out HAVE_NEON is unused so I've cleaned it up. I think all source-level optimizations should get enabled as long as you have the right CFLAGS or your toolchain has them preconfigured and patches like this are not needed.

@notaz notaz closed this Dec 15, 2025
@cscd98
Copy link
Author

cscd98 commented Dec 16, 2025

I wish there was 64-bit webOS TVs but there is none at present.

webOS TVs are 32-bit userspace on a 64-bit linux kernel. All the libretro cores are compiled for 32-bit for this platform (should that change, I will have quite a time updating them!).

HAVE_NEON_ASM is unset so the neon optimized code is unused.

I've updated my PR which should exclude aarch64:

# webOS
ifneq (,$(findstring webos,$(CROSS_COMPILE)$(findstring starfish,$(CROSS_COMPILE))))
	ifeq (,$(findstring aarch64,$(CROSS_COMPILE)))
		HAVE_NEON_ASM = 1
		BUILTIN_GPU = neon
	endif
endif

I think I might start using this from now on for other cores.

Is the neon path compatible with softfp?

@notaz
Copy link
Collaborator

notaz commented Dec 16, 2025

HAVE_NEON_ASM is unset so the neon optimized code is unused.

Your CFLAGS might be missing -mfpu=neon or something, Makefile.libretro has this and it should detect it:

ifndef HAVE_NEON_ASM
HAVE_NEON_ASM = $(shell $(CC) -E -dD $(CFLAGS) include/arm_features.h | grep -q HAVE_NEON32 && echo 1 || echo 0)
endif

Is the neon path compatible with softfp?

Yes, it's what it was written for. Shouldn't matter in practice as standard float isn't used anywhere.

@cscd98
Copy link
Author

cscd98 commented Dec 16, 2025

Ah that explains it. It works, thanks

Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Dec 21, 2025
-----------------------------------------------------------------------------------------------------
batocera-controlcenter.mk a21068a6297ed410c522c1caea9401d8440043c6 # Version: Commits on Dec 16, 2025
-----------------------------------------------------------------------------------------------------
Better consistency in <pdf> attributes + simplified default XML,

--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk 1ff81c9ec287580250f2f0cd445e03c49e178c47 # Version: Commits on Dec 16, 2025
--------------------------------------------------------------------------------------------------------
Merge pull request #2028 from ZaparooProject/zaparoo-redone

Integrate Zaparoo in the emulation station UI,

------------------------------------------------------------------------------------------------
batocera-es-piboy.mk 1ff81c9ec287580250f2f0cd445e03c49e178c47 # Version: Commits on Dec 16, 2025
------------------------------------------------------------------------------------------------
Merge pull request #2028 from ZaparooProject/zaparoo-redone

Integrate Zaparoo in the emulation station UI,

------------------------------------------------------------------------------------------
duckstation.mk 6062f5e2f8cdbfb96a99efccd2bc15c78b0e3ea0 # Version: Commits on Dec 16, 2025
------------------------------------------------------------------------------------------
Qt: Use same changed colour in memory scanner as view

More readable.,

----------------------------------------------------
pcsx2.mk v2.5.392 # Version: Commits on Dec 16, 2025
----------------------------------------------------
- [GS/DX12: Use aliasing resources for feedback](PCSX2/pcsx2#13653)

,

-------------------------------------------------------------------------------------
ppsspp.mk afc082dad940956b4c77b710f4c419a602378d6e # Version: Commits on Dec 16, 2025
-------------------------------------------------------------------------------------
Merge pull request #21074 from hrydgard/misc-fixes-2

Fix reported heap/buffer overflows,

------------------------------------------------------------------------------------
rpcs3.mk b1089ab1a3150bd5810c7bf3956987d2ad438639 # Version: Commits on Dec 04, 2025
------------------------------------------------------------------------------------
Fix hypervisor context memory placement,

--------------------------------------------------------------------------------------
tsugaru.mk 8b9560f546e8a64e088e01ce6db8b759f1ce5fd4 # Version: Commits on Dec 16, 2025
--------------------------------------------------------------------------------------
Support differential mouse integration for game port 0.,

-------------------------------------------------------------------------------------
ikemen.mk ed18070c2755495f8dc318e1aca92f6ecd4f787b # Version: Commits on Dec 16, 2025
-------------------------------------------------------------------------------------
Merge pull request #2970 from ikemen-engine/fix4

fix: victory screen regressions,

---------------------------------------------------------------
ruffle.mk nightly-2025-12-16 # Version: Commits on Dec 16, 2025
---------------------------------------------------------------
## What's Changed

* build(deps): bump the cargo-minor group with 2 updates by @dependabot[bot] in ruffle-rs/ruffle#22525

* chore: Update translations from Crowdin by @kjarosh in ruffle-rs/ruffle#22526

* build(deps): bump actions/upload-artifact from 5 to 6 by @dependabot[bot] in ruffle-rs/ruffle#22522

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-12-15...nightly-2025-12-16,

--------------------------------------------------------------------------------------
scummvm.mk 97d7eaf1dfa3b1f53ccbed26265b0726fecf05d5 # Version: Commits on Dec 16, 2025
--------------------------------------------------------------------------------------
IOS7: Disable bounces of the ScrollView containing the toolbar

The \extra\ toolbar with additional buttons, e.g. the function buttons,

lives within a ScrollView because all buttons doesn't fit within the

screen boundries.

Disable bounces of the ScrollView so if scrolling \too far\ so no

black background can be seen when scrolling outside the UITabBar

edges.

(cherry picked from commit dd673cecbbc0e17b9e630510569ee5f2e7d53c32),

---------------------------------------------------------------------------------------
thextech.mk 31178e3f63470b9dfb7e663d0555a141f345eb45 # Version: Commits on Dec 15, 2025
---------------------------------------------------------------------------------------
npc_activation: fix 1.3.7.1 bug where gen NPCs despawned while onscreen

(#996),

-------------------------------------------------------------------------------------------
sdl12-compat.mk 2eea59a1e9a133ffad3dfa1fe194b7cf0547819a # Version: Commits on Dec 16, 2025
-------------------------------------------------------------------------------------------
updated dr_mp3.h from mainstream.,

-----------------------------------------------------------------------------------------
sdl3_mixer.mk 2bcd961e04e0166e5590fd4ad6a5056d34dfcc1c # Version: Commits on Dec 16, 2025
-----------------------------------------------------------------------------------------
updated dr_mp3.h and dr_flac.h from mainstream.

(cherry picked from commit 19a1a38313b9e1c38243cbf8fec1d5673ad63cdb),

------------------------------------------------------------------------------------
box64.mk 57f1b60fb05a1a8cefbc5d66ad4ec6a25c867130 # Version: Commits on Dec 16, 2025
------------------------------------------------------------------------------------
[LA64_DYNAREC] Fixed a potential issue of the ADDxREGy macro ([RV64_DYNAREC] too) (#3284),

------------------------------------------------------------------------------------------
devilutionx.mk ec540871f75a1e3334eb1951d3d5c80a5643906c # Version: Commits on Dec 16, 2025
------------------------------------------------------------------------------------------
Bundle Hebrew font,

----------------------------------------------------------------------------------------
openmohaa.mk 9fd2fb13f15be316537874e7ca4438d3a979b22e # Version: Commits on Dec 15, 2025
----------------------------------------------------------------------------------------
feat(fgame): add an optional parameter to removeclass and killclass to control subclass inclusion (#863)

Subclasses are included by default.,

-----------------------------------------------------------------------------------
rott.mk f9c646237ea43e782c042b74a8b2fd3586df203c # Version: Commits on Dec 16, 2025
-----------------------------------------------------------------------------------
Release Taradino 2025.12.16,

--------------------------------------------------------------------------------------
stalker.mk bf1c14f0fe1670766008e57b0db188e78541f052 # Version: Commits on Dec 16, 2025
--------------------------------------------------------------------------------------
unite generations,

----------------------------------------------------------------------------------------
supertux2.mk e899c3dc5c05deebb47c10fd82222d0f629cd68e # Version: Commits on Dec 16, 2025
----------------------------------------------------------------------------------------
Fix linter issue,

----------------------------------------------------------------------------------------
retroarch.mk 219bc218fbbb7972906ab5c9b755fe1f6b14573c # Version: Commits on Dec 16, 2025
----------------------------------------------------------------------------------------
macos: adjust CADisplaylink stutter-fix version conditions,

---------------------------------------------------------------------------------------------
easyrpg-player.mk a5207b744613960af5869eb541675956fd09b61f # Version: Commits on Dec 15, 2025
---------------------------------------------------------------------------------------------
Merge pull request #3507 from Ghabry/cmake-lint

Fix CMake Linter error,

--------------------------------------------------------------------------------------
vkquake.mk e4b0f21fd20a69eb121334031928c38902c4857a # Version: Commits on Dec 15, 2025
--------------------------------------------------------------------------------------
Fix #836 : MD3 skinfile did not matched surface names properly,

----------------------------------------------------------------------------------
trx.mk 39c9300239d83224b8b0195c1165b56560ed717f # Version: Commits on Dec 16, 2025
----------------------------------------------------------------------------------
data: add new high-resolution images for TR2,

--------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk d2da8bc99de0782c4856ea3ab553a74b4ebdff02 # Version: Commits on Dec 16, 2025
--------------------------------------------------------------------------------------------------
Update common.,

-----------------------------------------------------------------------------------------------
libretro-easyrpg.mk a5207b744613960af5869eb541675956fd09b61f # Version: Commits on Dec 15, 2025
-----------------------------------------------------------------------------------------------
Merge pull request #3507 from Ghabry/cmake-lint

Fix CMake Linter error,

-------------------------------------------------------------------------------------------------
libretro-geargrafx.mk 7c459a4d101f8c633cbf58c1536845859e903015 # Version: Commits on Dec 15, 2025
-------------------------------------------------------------------------------------------------
Fix SBC instruction,

--------------------------------------------------------------------------------------------
libretro-pcsx.mk 8d91fbdff8f4db6e256370f030a9f6ac8c7f2c62 # Version: Commits on Dec 15, 2025
--------------------------------------------------------------------------------------------
drop the unused HAVE_NEON

only results in confusion like in libretro/pcsx_rearmed#899,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk afc082dad940956b4c77b710f4c419a602378d6e # Version: Commits on Dec 16, 2025
----------------------------------------------------------------------------------------------
Merge pull request #21074 from hrydgard/misc-fixes-2

Fix reported heap/buffer overflows,

-----------------------------------------------------------------------------------------------
libretro-scummvm.mk 97d7eaf1dfa3b1f53ccbed26265b0726fecf05d5 # Version: Commits on Dec 16, 2025
-----------------------------------------------------------------------------------------------
IOS7: Disable bounces of the ScrollView containing the toolbar

The \extra\ toolbar with additional buttons, e.g. the function buttons,

lives within a ScrollView because all buttons doesn't fit within the

screen boundries.

Disable bounces of the ScrollView so if scrolling \too far\ so no

black background can be seen when scrolling outside the UITabBar

edges.

(cherry picked from commit dd673cecbbc0e17b9e630510569ee5f2e7d53c32),

---------------------------------------------------------------------------------------------
libretro-vba-m.mk c4c06bd20f7a7121531a2dc4763556f02d1dd3a8 # Version: Commits on Dec 16, 2025
---------------------------------------------------------------------------------------------
translations: transifex pull

Signed-off-by: Rafael Kitover <[email protected]>,
notaz added a commit to notaz/pcsx_rearmed that referenced this pull request Dec 26, 2025
only results in confusion like in libretro#899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants