-
Notifications
You must be signed in to change notification settings - Fork 71
Fix compiling to webOS #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Helix sources aren't provided for licensing issues in the picodrive repo. |
|
Does it need them to compile? I can always look at another fix (it compiles fine atm) |
|
No, it compiles in a shard library loader for helix. However, there wouldn't be mp3 sound output without that shard library in place. |
|
OK i'll see about another fix then 👍 |
|
I remember having something similar for another lr platform ages ago. Let me try to find it. |
|
Look at platform/common/mp3_drmp3.c. In line 13, it checks for libretro VFS usage and cuts out some functions. That would be a good place to add something for this special case. Defining a wrapper function for fopen64 to use fopen in case it is compiled on webos is probably the simplest method. |
|
Thanks, updated PR 👍 |
|
I've adjusted the way CYCLONE_CC/CXX is passed as otherwise it was still picking up the arm compiler instead of the native one. |
d7b2285 to
e7c84cf
Compare
…rom incompatible pointer type ‘FILE *’
c3e3893 to
9e93711
Compare
Currently fails to build due an issue with dr_mp3
So switched to MP3 helix (as it is ARM).. 👍