Skip to content

Conversation

@davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Nov 12, 2025

Changes

  • Merge Sony_DualShock_4_Controller.cfg (v1) and v2 by using alternative vid/pid: Autoconfig extension with alternative name/vid/pid RetroArch#16990. Used the official name, Wireless Controller.cfg, generated for Sony DualShock 4 v2 by RetroArch.
  • The merged autoconfigs makes the Sony DualShock 4 Controller v1 use correct mappings
    • Sony_DualShock_4_Controller.cfg file used input_menu_toggle_btn = "109" which is now set to input_menu_toggle_btn = "110" in Wireless Controller.cfg: Changes the menu button from the Touchpad (does not work at all) to the PS button.
    • Sony_DualShock_4_Controller.cfg file used input_select_btn = "4" which is now set to input_select_btn = "109" in Wireless Controller.cfg
  • Added " Trigger" to the labels for the triggers.

Compatibility

Reviewing

This PR (#1276) is stable. It is a duplicate of my old PR that has already been reviewed.

#1171 had merge conflicts that no one could help me solve. So I merged it to this PR (#1276) after I asked hizzlekizzle for help and he told me "I would recommend copying those files somewhere else temporarily, close your PRs, resync your repo by discarding your commits (via github web interface), delete your local copy of the repo, re-clone your now-synced repo, re-apply your changed files, make a new commit, submit a new PR". I followed his instructions, so let's hope that it working this time!

Check issue: Travis CI through GitHub services integration

My fresh fork of retroarch-joypad-autoconfig was made today (2025-11-12). But this PR (#1276) still get:

1 pending check
continuous-integration/travis-ci Expected — Waiting for status to be reported

I was informed by the GitHub community that the Travis check is stuck because Travis CI is no longer active or linked to the repository. There is nothing wrong with the pull request; the repository maintainers need to remove or replace the Travis check in the branch protection settings. Once that is done, your pull request will show all checks as complete.

I encountered this check issue with at least one pull request in my previous fork of the repository as early as July 2025. Therefore, the issue definitely exists in the main repository.

…roller.cfg

* Merge Sony_DualShock_4_Controller.cfg (v1) and v2 by using alternative vid/pid: libretro/RetroArch#16990
* The merged autoconfigs makes the Sony DualShock 4 Controller v1 use correct mappings
  - Sony_DualShock_4_Controller.cfg file used `input_menu_toggle_btn = "109"` which is now set to `input_menu_toggle_btn = "110"` in `Wireless Controller.cfg`: Changes the menu button from the Touchpad (does not work at all) to the PS button.
  - Sony_DualShock_4_Controller.cfg file used `input_select_btn = "4"` which is now set to `input_select_btn = "109"` in `Wireless Controller.cfg`
* Renamed the controller to the official name generated by RetroArch.
* Added " Trigger" to the labels for the triggers.
Merged `Sony_DualShock_4_Controller.cfg` to `Wireless Controller.cfg`; Merged Sony_DualShock_4_Controller.cfg (v1) and v2 by using alternative vid/pid: libretro/RetroArch#16990

See commit
* d6b8ed1
@davidhedlund davidhedlund changed the title android: Update and rename Sony_DualShock_4_Controller_v2.cfg to Wireless Controller.cfg android: Merge Sony DualShock 4 v1 and v2 to Wireless Controller.cfg Nov 12, 2025
Comment on lines -4 to -5
input_vendor_id = "1356"
input_product_id = "1476"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lose this vendor/product id pair by doing this. Would it be worth just having the files be the same, but with the diff product_id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants