WIN_ShowCursor function is now capable of processing NULL as a SDL_Cursor* (repost) #13713
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now a new SDL hint is available for use. SDL_HINT_WINDOWS_FORCE_NULL_CURSOR can be set to 1 if the Windows cursor is specifically needed to be NULL, such as in VM's.
|
all good? |
Gabrunken
changed the title
|
btw you guys have a discord solely for this?? would be cool to join |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an SDL Hint called "SDL_HINT_WINDOWS_FORCE_NULL_CURSOR" which lets you decide
to have a NULL windows cursor, which is the intended way to hide it in a window, or "fake" by making it invisible.
Now the issue was that since GetCursorPos wasnt working when the cursor was NULL, and for other reasons,
this commit (8fee82d) fixed it by putting a blank surface as the cursor (hiding it); altho this wasn't working properly on Vitual Machines such as VMWare Workstation Pro when the SDL app in fullscreen, since the cursor was effectively not there, but when moved could exit the VM, which is unwanted behaviour. With this SDL Hint you can decide that (0 for fake cursor, 1 for actual NULL pointer).
This was tested in VMWare Workstation Pro with Windows 10 64 bit, using SDL3 SDL_HideCursor() function.
Fixed issue #13700