GPU: Fix memory leak when creating D3D12 compute pipelines #14760
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm going to mark this as draft, please let us know when you test it! |
Contributor
Author
|
I no longer use the GPU API in my own projects so I'm unable to test this myself. |
Collaborator
|
@flibitijibibo, @TheSpydog, can you review this? |
flibitijibibo
approved these changes
Jan 5, 2026
Collaborator
flibitijibibo
left a comment
flibitijibibo
left a comment
There was a problem hiding this comment.
Makes sense, we only need the compiled shader handle and now the raw bytecode.
Collaborator
|
@flibitijibibo, are you able to actually test this? |
Collaborator
|
Not for a while since my only compute cases are the examples. @thatcosmonaut may be able to look once he's back in the office. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D3D12_CreateComputePipeline() currently leaks memory on the success path as it makes a copy of the shader bytecode but never releases it. As D3D12 doesn't need the bytecode to remain valid after the call to ID3D12Device_CreateComputePipelineState() it's possible to use the original bytecode and avoid the copy outright.
This PR was made blindly via the GitHub website. I have not tested this change directly.