x11: fix compilation failure on older XInput2 #14773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of XInput2 do not declare struct XIGesturePinchEvent in XInput2.h, causing compilation failure in SDL_x11xinput2.c Check for XIGesturePinchEvent in the test for enabling SDL_VIDEO_DRIVER_X11_XINPUT2_SUPPORTS_GESTURE
Contributor
Author
|
This is the compilation failure fixed by this PR, compiling SDL 3.4.0 on an older distro (openSUSE LEAP 15.5): |
Collaborator
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of XInput2 do not declare
struct XIGesturePinchEventinXInput2.h(nor anywhere else), causing compilation failure inSDL_x11xinput2.c.Check for
XIGesturePinchEventin the test for enablingSDL_VIDEO_DRIVER_X11_XINPUT2_SUPPORTS_GESTURE