Skip to content

Conversation

@erysdren
Copy link
Contributor

@erysdren erysdren commented Jan 7, 2026

The current code was not checking if GetModeList succeeded, so in some cases it would free a bogus pointer.

@icculus
Copy link
Collaborator

icculus commented Jan 7, 2026

I think zeroing out bmodes and count at start would have fixed this too, but actually checking error codes isn't a terrible idea in any case. Merging!

@icculus icculus merged commit 1dda484 into libsdl-org:SDL2 Jan 7, 2026
34 checks passed
@icculus
Copy link
Collaborator

icculus commented Jan 7, 2026

Just saw @slouken's comments on #14778, I'll fix this that up in what I just merged and take care of the other PR real fast, too.

icculus added a commit that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants