Use conda version of libsemigroups in the CI#240
Closed
Joseph-Edwards wants to merge 5 commits intolibsemigroups:v1from
Closed
Use conda version of libsemigroups in the CI#240Joseph-Edwards wants to merge 5 commits intolibsemigroups:v1from
libsemigroups in the CI#240Joseph-Edwards wants to merge 5 commits intolibsemigroups:v1from
Conversation
Joseph-Edwards
force-pushed
the
ci-use-conda
branch
3 times, most recently
from
46ce2ea to
53d427b
Compare
Joseph-Edwards
force-pushed
the
ci-use-conda
branch
from
e80020d to
0a5d895
Compare
Joseph-Edwards
force-pushed
the
ci-use-conda
branch
2 times, most recently
from
9bcf0b2 to
8104c37
Compare
Joseph-Edwards
force-pushed
the
ci-use-conda
branch
from
3e85549 to
57f3ef0
Compare
Collaborator
Author
|
This now seems to be working as expected (passing on the main branch, failing when running the doctest in the conda version). For an example of the action that uses a specific fork and branch of libsemigroups, see this example on my fork. |
james-d-mitchell
approved these changes
May 1, 2025
Member
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Looks good to me, should we maybe hold off merging this until we’ve released a new version of libsemigroups?
Collaborator
Author
Yeah that seems sensible |
Collaborator
Author
|
Closed in favour of #346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CI to use the conda version of
libsemigroups, and also adds a job that uses the main version oflibsemigroups.