Convert from KnuthBendix and a word type to a Presentation.#243
Merged
james-d-mitchell merged 5 commits intolibsemigroups:v1from May 31, 2025
Merged
Convert from KnuthBendix and a word type to a Presentation.#243james-d-mitchell merged 5 commits intolibsemigroups:v1from
KnuthBendix and a word type to a Presentation.#243james-d-mitchell merged 5 commits intolibsemigroups:v1from
Conversation
Collaborator
Author
|
This will fail until libsemigroups/731 is merged into stable-3.0, and stable-3.0 is merged into main. |
james-d-mitchell
approved these changes
May 16, 2025
Member
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Looks great thanks @Joseph-Edwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of a minor refactor of the
tofunction that removes unnecessary lambdas, and adds the option to convert aKnuthBendixobject to aPresentationover words with a specified type.