Sync Forest and its helpers with recent changes in libsemigroups#347
Conversation
Joseph-Edwards
left a comment
There was a problem hiding this comment.
This looks good to me. I've requested one small doc change, and made one comment, but otherwise I'm happy for this to be merged.
It's worth noting that we expect this to fail the conda libsemigroups jobs. This raises the question that maybe they should only be run when making PRs into stable-*, or on a release? What do you think @james-d-mitchell?
I think that'd be a good idea, this way we'll only see proper errors, not out of sync issues like this. |
9314878 to
5e82f9d
Compare
Will require
libsemigroups/libsemigroups#847
to be merged before the ci here will pass.