Skip to content

Sync presentation#351

Merged
james-d-mitchell merged 3 commits intolibsemigroups:mainfrom
james-d-mitchell:sync-presentation
Nov 10, 2025
Merged

Sync presentation#351
james-d-mitchell merged 3 commits intolibsemigroups:mainfrom
james-d-mitchell:sync-presentation

Conversation

@james-d-mitchell
Copy link
Copy Markdown
Member

This PR adds support for 3 helper functions from libsemigroups that were not supported before. I think this means that all helper functions that we want to support from presentation are now supported.

Copy link
Copy Markdown
Collaborator

@Joseph-Edwards Joseph-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, mod the removal of the empty line that cpplint is complaining about.

A few of our recent PRs have been introducing whitespace/formatting changes on otherwise unchanged lines. This is fine for this PR, but we should probably discuss and settle on a common formatter to avoid this moving forward.

Comment thread src/present.cpp Outdated
@james-d-mitchell
Copy link
Copy Markdown
Member Author

This all looks good to me, mod the removal of the empty line that cpplint is complaining about.

A few of our recent PRs have been introducing whitespace/formatting changes on otherwise unchanged lines. This is fine for this PR, but we should probably discuss and settle on a common formatter to avoid this moving forward.

Agreed, one or the other of us is using the wrong thing to format the files, and we are cycling back and forth between the differences.

@james-d-mitchell james-d-mitchell merged commit 8b3472e into libsemigroups:main Nov 10, 2025
15 of 17 checks passed
@james-d-mitchell james-d-mitchell deleted the sync-presentation branch November 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants