Sync presentation#351
Conversation
Joseph-Edwards
left a comment
There was a problem hiding this comment.
This all looks good to me, mod the removal of the empty line that cpplint is complaining about.
A few of our recent PRs have been introducing whitespace/formatting changes on otherwise unchanged lines. This is fine for this PR, but we should probably discuss and settle on a common formatter to avoid this moving forward.
Agreed, one or the other of us is using the wrong thing to format the files, and we are cycling back and forth between the differences. |
b3b4670 to
09e9edf
Compare
This PR adds support for 3 helper functions from
libsemigroupsthat were not supported before. I think this means that all helper functions that we want to support frompresentationare now supported.