Make windows path compile for both C and C++ direct file include case #718
+51
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also make it work for older WINVER cases by copying a few defines
Youw
approved these changes
Feb 25, 2025
Member
Youw
left a comment
Youw
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Would you be willing to add a simple compilation check for this to our CI script?
Contributor
Author
|
Willing: Yes. Capable: No. ;) |
Member
|
Maybe later then |
| coll_bit_range[collection_node_idx] = (rd_bit_range ***)malloc(256 * sizeof(*coll_bit_range[0])); // 256 possible report IDs (incl. 0x00) | ||
| for (int reportid_idx = 0; reportid_idx < 256; reportid_idx++) { | ||
| coll_bit_range[collection_node_idx][reportid_idx] = malloc(NUM_OF_HIDP_REPORT_TYPES * sizeof(*coll_bit_range[0][0])); | ||
| for (HIDP_REPORT_TYPE rt_idx = 0; rt_idx < NUM_OF_HIDP_REPORT_TYPES; rt_idx++) { |
Contributor
There was a problem hiding this comment.
Replacing the explicit enum type HIDP_REPORT_TYPE by int feels not like an improvement to me.
Member
There was a problem hiding this comment.
I believe this PR is to make the compiler happy with some of the strict checks.
And enums has never been intended to be used as iteration indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also make it work for older WINVER cases by copying a few defines
this is how we intend/want to use it within https://github.com/vpinball/vpinball, so would be nice to have that in the official repo