-
Notifications
You must be signed in to change notification settings - Fork 23
Add Github Action winget-releaser #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I would prefer not to create a personal access token (PAT) for automatically submitting PRs on https://github.com/microsoft/winget-pkgs, as that would make me personally accountable for all automated changes and could introduce security risks. Furthermore, redistributing binaries outside this repository is beyond my scope. |
Thanks for getting back so fast. Understood that you do not want to create a PAT.
Do you think other members of libvips team like john share the same mindset regarding using a PAT? If so, please do not hesitate to close this PR. Letting the community push manually new releases to the winget package repository would still probably end up with libvips winget package being almost up-to-date. And thanks for all the hard work! |
Hi Jo, thanks for the PR, would you be willing and able to become the "official" winget libvips maintainer? If so, perhaps we could do this from a separate repo? |
c7c4f7d
to
2e2f6b6
Compare
2fdb548
to
e8375dd
Compare
d142546
to
04feb9b
Compare
Thanks both for getting back. I've tried various ways of automating things on my side (building and publishing the libvips windows builds), but in the end I'd rather have the libvips winget package manifest have an installer url that points to the github release on the official libvips repo rather than my fork for various reasons, trust/security being one of them. Since it's probably better to not make me one of the repo team member, I finally found an alternative github action workflow, winget-updater which also relies on Komac. I already have a winget-pkgs fork, and added a workflow in it, which will run periodically via cron, and pushes latest libvips github release to winget repo PR if its version is more recent than current winget package version. It's here if you want to have a look. This means we can close this PR if you want to proceed this way! |
In relation to #66
This github action requires
public_repo
scope is created, following this linkWINGET_ACC_TOKEN
.