Remove rect_graphene_to_vips() utility
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes I think I switched to graphene rects because I was worried I was going to int coordinates too early and losing precision. But your tile snapping is a much better solution, so I expect VipsRect is fine there. |
kleisauke
force-pushed
the
remove-graphene-to-vips-util
branch
from
e6389f9 to
2db4224
Compare
It's simpler to do these calculations ourselves. Non-functional change.
kleisauke
force-pushed
the
remove-graphene-to-vips-util
branch
from
2db4224 to
85f3568
Compare
Member
Author
|
This PR no longer contains any possible functional changes. |
Member
|
Great! |
Member
|
I'll do 4.1.1, that TIFF pyr detection bug is bad. |
kleisauke
added a commit
to kleisauke/nip4
that referenced
this pull request
Aug 22, 2025
Incorporates: libvips/vipsdisp#53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's simpler to do these calculations ourselves.
Non-functional change.