Skip to content

Make TLS enabled proxy work (proxy URL https:// not http://) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noxxi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make TLS enabled proxy work (proxy URL https:// not http://) #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/LWP/Protocol/https.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,26 @@ if ( $Net::HTTPS::SSL_SOCKET_CLASS->can('start_SSL')) {
# SNI should be passed there only if it is not an IP address.
# Details: https://github.com/libwww-perl/libwww-perl/issues/449#issuecomment-1896175509
my $host = $url->host() =~ m/:|^[\d.]+$/s ? undef : $url->host();
$sock = LWP::Protocol::https::Socket->start_SSL( $sock,
my $usebio = {};
if (UNIVERSAL::can($sock,'is_SSL') && $sock->is_SSL) {
$usebio = eval { $Net::HTTPS::SSL_SOCKET_CLASS->can_nested_ssl } or
die "no support for nested TLS in this IO::Socket::SSL version";
}

$sock = LWP::Protocol::https::Socket->start_SSL( my $osock = $sock,
SSL_verifycn_name => $url->host,
SSL_hostname => $host,
%$usebio,
$self->_extra_sock_opts,
);
$@ = LWP::Protocol::https::Socket->errstr if ! $sock;
if (!$sock) {
$@ = LWP::Protocol::https::Socket->errstr;
return;
}
if ($usebio and my @fields = grep { /^http_/ } keys %{*$osock}) {
# propagate any http_ fields from osock to sock
@{*$sock}{@fields} = @{*$osock}{@fields}
}
return $sock;
}
}
Expand Down
Loading