[Tune] Introduce tpp-tune #1059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Segment of updated ...
%13 = transform.apply_registered_pass "pack-conv2DNhwcHwcf" to %12 : (!transform.any_op) -> !transform.any_op
%14 = transform.apply_registered_pass "rewrite-conv-to-matmul-or-brgemm" to %13 : (!transform.any_op) -> !transform.any_op
%15 = transform.tune.select @m from [2, 4, 8] : !transform.any_param
%16 = transform.tune.select @n from [4, 8, 16] : !transform.any_param
%17 = transform.tune.select @k from [2, 4, 8, 16] : !transform.any_param
%18 = transform.apply_registered_pass "pack-matmul" with options = {"block-factors" = [%15, %16, %17]} to %14 : (!transform.any_op, !transform.any_param, !transform.any_param, !transform.any_param) -> !transform.any_op
%19 = transform.apply_registered_pass "pack-vnni" to %18 : (!transform.any_op) -> !transform.any_op
%20 = transform.structured.match ops{["func.func"]} in %10 : (!transform.any_op) -> !transform.any_op
...Corresponding segment of ...
%13 = transform.apply_registered_pass "pack-conv2DNhwcHwcf" to %12 : (!transform.any_op) -> !transform.any_op
%14 = transform.apply_registered_pass "rewrite-conv-to-matmul-or-brgemm" to %13 : (!transform.any_op) -> !transform.any_op
%15 = transform.param.constant 2 : i64 -> !transform.any_param
%16 = transform.tune.select @m from [2, 4, 8] : !transform.any_param
%17 = transform.param.constant 4 : i64 -> !transform.any_param
%18 = transform.tune.select @n from [4, 8, 16] : !transform.any_param
%19 = transform.param.constant 2 : i64 -> !transform.any_param
%20 = transform.tune.select @k from [2, 4, 8, 16] : !transform.any_param
%21 = transform.apply_registered_pass "pack-matmul" with options = {"block-factors" = [%15, %17, %19]} to %14 : (!transform.any_op, !transform.any_param, !transform.any_param, !transform.any_param) -> !transform.any_op
%22 = transform.apply_registered_pass "pack-vnni" to %21 : (!transform.any_op) -> !transform.any_op
%23 = transform.structured.match ops{["func.func"]} in %10 : (!transform.any_op) -> !transform.any_op
...And the corresponding segment of ...
%13 = transform.apply_registered_pass "pack-conv2DNhwcHwcf" to %12 : (!transform.any_op) -> !transform.any_op
%14 = transform.apply_registered_pass "rewrite-conv-to-matmul-or-brgemm" to %13 : (!transform.any_op) -> !transform.any_op
%15 = transform.param.constant 2 : i64 -> !transform.any_param
%16 = transform.param.constant 4 : i64 -> !transform.any_param
%17 = transform.param.constant 2 : i64 -> !transform.any_param
%18 = transform.apply_registered_pass "pack-matmul" with options = {"block-factors" = [%15, %16, %17]} to %14 : (!transform.any_op, !transform.any_param, !transform.any_param, !transform.any_param) -> !transform.any_op
%19 = transform.apply_registered_pass "pack-vnni" to %18 : (!transform.any_op) -> !transform.any_op
%20 = transform.structured.match ops{["func.func"]} in %10 : (!transform.any_op) -> !transform.any_op
... |
Walks schedule IR, collects options (name -> values mapping), calls an `autotune` procedure (dummy implementation just selects first value) to select one value for each name, walks schedule IR again to introduce a param constant for the each option's value and replaces the users of the `transform.tune.select` op with the constant op's result. Run it as `tpp-sched | tpp-tune` where `tpp-sched` produces IR containing `transform.tune.select` ops.
rolfmorel
commented
Jun 16, 2025
tools/tpp-tune/tpp-tune.py
Outdated
Comment on lines
32
to
34
| def autotune(choices: Dict[str, Sequence[ir.Attribute]]) -> Dict[str, ir.Attribute]: | ||
| # Aint tuning easy!! | ||
| return {key: values[0] for key, values in choices.items()} |
Contributor
Author
There was a problem hiding this comment.
Just need to replace this function's implementation to make it useful.
adam-smnk
reviewed
Jun 17, 2025
Contributor
Author
|
Latest update allows for specifying options via commandline, e.g. %15 = transform.param.constant 8 : i64 -> !transform.any_param
%16 = transform.tune.select @m from [2, 4, 8] : !transform.any_param
%17 = transform.param.constant 4 : i64 -> !transform.any_param
%18 = transform.tune.select @n from [4] : !transform.any_param
%19 = transform.param.constant 16 : i64 -> !transform.any_param
%20 = transform.tune.select @k from [8, 16, 32] : !transform.any_param
%21 = transform.apply_registered_pass "pack-matmul" with options = {"block-factors" = [%15, %17, %19]} to %14 : (!transform.any_op, !transform.any_param, !transform.any_param, !transform.any_param) -> !transform.any_op |
Contributor
Author
|
transform.tune.pick: tune.select but without forgetting the options: %15 = transform.param.constant 4 : i64 -> !transform.any_param
%16 = transform.tune.select @m from [2, 4, 8] : !transform.any_param
%17 = transform.param.constant 4 : i64 -> !transform.any_param
%18 = transform.tune.select @n from [4] : !transform.any_param
%19 = transform.tune.pick @k from [8, 16, 32] {selected = 8 : i64} : !transform.any_param
%20 = transform.apply_registered_pass "pack-matmul" with options = {"block-factors" = [%15, %17, %19]} to %14 : (!transform.any_op, !transform.any_param, !transform.any_param, !transform.any_param) -> !transform.any_op |
Contributor
Author
|
Closing due to feature getting merged upstream: llvm/llvm-project#146732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walks schedule IR, collects options (name -> values mapping), calls an
autotuneprocedure (dummy implementation just selects first value) to select one value for each name, walks schedule IR again to introduce a param constant for the each option's value and replaces the users of thetransform.tune.selectop with the constant op's result.Run it as
tpp-sched | tpp-tunewheretpp-schedproduces IR containingtransform.tune.selectops.