Skip to content

Feature/clear alerts on player change#1016

Open
thomassedlmayer wants to merge 2 commits intolichtblick-suite:developfrom
thomassedlmayer:feature/clear-alerts-on-player-change
Open

Feature/clear alerts on player change#1016
thomassedlmayer wants to merge 2 commits intolichtblick-suite:developfrom
thomassedlmayer:feature/clear-alerts-on-player-change

Conversation

@thomassedlmayer
Copy link
Copy Markdown
Contributor

User-Facing Changes

Message converter alerts are cleared when opening a new source/player.

Description

I noticed that I forgot to clear alerts when opening a new source over an already open one in #943. Currently, any alerts that were emitted from previous message conversions are kept across opened sources. This adds ambiguity about which source lead to the alert. Message converters can't create source-aware alert IDs because they don't know anything about the source.

Since message converters are the only component that use session alerts right now, this change only affects alerts emitted by message converters.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant