Fix - Support typed arrays in raw messages panel#998
Open
benedikt-schwering wants to merge 1 commit intolichtblick-suite:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Previously the Raw Messages Panel was unable to show values from typed arrays.
Now typed array entries are expandable and will be displayed.
Also the value hint is corrected from "{} x keys" to "[] x items".
Description
This PR fixes the Issue #927.
The problem was that typed arrays are treated as opaque objects which hides their values.
Converting them to normal JS Arrays before rendering solved the issue.
Also the hover action was throwing errors for these arrays sometimes.
Because the hover action function only returns optional actions, a graceful fail prevents crashing the whole panel.
Checklist