Bugfix/withdrawal queue guard#1654
Open
Dev-In-Crypt wants to merge 2 commits intolidofinance:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This touches the withdrawal request flow. The requested stETH amount and share amount are later handled in a context that expects values to fit into uint128, so we should fail early with a clear error instead of allowing an implicit truncation or a confusing downstream revert.
Problem
_requestWithdrawal and _requestWithdrawalWstETH accept user supplied amounts that can exceed type(uint128).max. If oversized values pass through, they can cause incorrect casting behavior or unexpected reverts later in the flow.
Solution
Add a dedicated error AmountTooLarge(uint256 _amount) and introduce explicit bounds checks in _requestWithdrawal and _requestWithdrawalWstETH. If amountOfStETH or amountOfShares is greater than type(uint128).max, the call reverts with AmountTooLarge, preventing unsafe or ambiguous behavior.