-
Notifications
You must be signed in to change notification settings - Fork 22
[WIP] Feature/earn new #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…rmation and upgrade options
…th styled elements
…kground transition
…get into feature/earn-new
Preview stand statusStand was demolished |
Signed-off-by: Alexander Khramov <[email protected]>
Signed-off-by: Alexander Khramov <[email protected]>
Signed-off-by: Alexander Khramov <[email protected]>
Signed-off-by: Alexander Khramov <[email protected]>
Signed-off-by: Alexander Khramov <[email protected]>
|
|
||
| const isEarnListPage = router.pathname === EARN_PATH; | ||
| const isEarnVault = router.pathname.includes(`${EARN_PATH}/[vault]/[action]`); | ||
| const isEarnVaultV1 = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: move this logic to layout props
| <TableGroup> | ||
| <TableItem> | ||
| <TableLabel>Curator</TableLabel> | ||
| <TableValue>● Mellow</TableValue> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add TODO
| @@ -0,0 +1,252 @@ | |||
| export const ETH_DEPOSIT_QUEUE_DVSTETH_ABI = [ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deposit queues have same ABIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can reuse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or at least part that's used by us is the same
| @@ -0,0 +1,260 @@ | |||
| export const ETH_REDEEM_QUEUE_WSTETH_ABI = [ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also feels like they are the same
| wETH: { | ||
| balance: wethBalanceQuery.data, | ||
| }, | ||
| GG: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this in form I think, updgrade will be done separtely
| 'collect', | ||
| collector.address, | ||
| vault.address, | ||
| { address: address ?? null }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to ??
| address, // account | ||
| vault.address, // vault | ||
| COLLECTOR_CONFIG, // config | ||
| ])) as CollectResponse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's wrong with viem types?
| import { getSTGCollectorContract, getSTGVaultContract } from '../contracts'; | ||
| import { STG_COLLECTOR_CONFIG } from '../consts'; | ||
|
|
||
| export type STGCollectResponse = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: use common collector hook
| @@ -0,0 +1,16 @@ | |||
| export const ETH_TOKEN_SYMBOL = 'earnETH'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's switch naming ETH_VAULT, ETH_ is too ambigous for stake widget
| const depositQueue = depositQueueGetter({ | ||
| publicClient: core.rpcProvider, | ||
| walletClient: core.web3Provider as WalletClient, | ||
| token, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for us to get correct depositQueue seems token is not eneough, we should also specify vault, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add vault: 'str' | 'eth" ... param to have general getter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
token is enough because we get correct vault by token
Description
WIP new earn
Demo
Code review notes
Testing notes
Checklist: