Skip to content

Omnibus 20.01.2026 (#198 - Lido V3 Phase 2, CSM Share → 7.5%, Grant role to CSM Performance Oracle report weekday offset contract)#580

Merged
iamnp merged 63 commits intofeat/next-votefrom
feat/v3-phase-2
Jan 19, 2026
Merged

Omnibus 20.01.2026 (#198 - Lido V3 Phase 2, CSM Share → 7.5%, Grant role to CSM Performance Oracle report weekday offset contract)#580
iamnp merged 63 commits intofeat/next-votefrom
feat/v3-phase-2

Conversation

@dry914
Copy link
Contributor

@dry914 dry914 commented Dec 30, 2025

Lido V3 phase 2 voting script.

@dry914 dry914 requested a review from a team as a code owner December 30, 2025 17:27
@dry914 dry914 marked this pull request as draft December 30, 2025 17:28
@dry914 dry914 changed the title feat: add v3 phase 2 script Lido V3 phase 2 voting Dec 30, 2025
Copy link
Contributor

@iamnp iamnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid ❤️
please address the comments

@iamnp iamnp changed the title Lido V3 phase 2 voting Omnibus 21.01.2026 (#198 - Lido V3 Phase 2, CSM Share → 7.5%, Grant role to CSM Performance Oracle report weekday offset contract) Jan 13, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements the Lido V3 Phase 2 voting script and comprehensive test suite. The PR contains three main components:

Purpose: Activate Lido V3 Phase 2 (Full Launch), increase Community Staking Module share limit to 7.5%, and grant permissions for CSM Performance Oracle weekday offset functionality.

Changes:

  • Submit a Dual Governance proposal with 15 sub-items including role migrations, proxy upgrades, parameter updates, and permission grants
  • Replace 7 Easy Track factories for Lido V3 vault management (old Phase 1 → new Phase 2)
  • Comprehensive test coverage with over 1,350 lines of test code including scenario tests and permission checks

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
utils/test/rpc_helpers.py New utility function for setting storage slots during testing, supporting multiple RPC methods (Hardhat, Anvil, Geth)
tests/test_2026_01_20.py Comprehensive test suite with voting execution, DG proposal execution, Easy Track factory migrations, and scenario tests
scripts/upgrade_2026_01_20_v3_phase_2.py Voting script implementing the proposal with 15 vote items
tests/snapshot/test_lido_snapshot.py Updated snapshot tests to account for max external ratio change (3% → 30%)
tests/regression/test_permissions.py Updated permission expectations for TwoPhaseFrameConfigUpdate contract
tests/regression/test_gate_seal.py Removed temporary PDG unpause code (now handled by the vote)
configs/config_mainnet.py Updated CSM parameters and VaultsAdapter address
interfaces/TwoPhaseFrameConfigUpdate.json New interface definition for the TwoPhaseFrameConfigUpdate contract
.github/workflows/*.yml CI workflow configuration updates (runner and branch changes)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TheDZhon
TheDZhon previously approved these changes Jan 19, 2026
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@failingtwice failingtwice marked this pull request as ready for review January 19, 2026 07:58
@iamnp iamnp merged commit 4b8fd47 into feat/next-vote Jan 19, 2026
3 of 5 checks passed
@iamnp iamnp deleted the feat/v3-phase-2 branch January 19, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants