add git action to keep ledger clear signing registry updated#1609
add git action to keep ledger clear signing registry updated#1609
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughAdds a GitHub Actions pinning guideline, a scheduled/manual workflow to regenerate and sync the Ledger Clear Signing (ERC-7730) registry, and a new TypeScript CLI that builds, diffs, and updates a Ledger registry JSON from Foundry artifacts and deployments. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/syncLedgerClearSigning.yml:
- Around line 92-99: Unset the default GITHUB_TOKEN and authenticate the gh CLI
with the custom PAT before calling gh commands: remove reliance on implicit
GITHUB_TOKEN by unsetting GITHUB_TOKEN, export GH_TOKEN="${LEDGER_SYNC_TOKEN}"
(or set a GH_PAT variable), and run gh auth login --with-token piping the PAT so
subsequent calls that use HEAD_REF and gh pr view / gh pr edit authenticate with
the provided PAT rather than the default token.
- Around line 22-30: Move the top-level concurrency block into the single job
definition so the workflow follows required section ordering: remove the
top-level "concurrency" and add a job-level concurrency entry under the
"sync-ledger" job (use the same group name "sync-ledger-clear-signing" and
"cancel-in-progress: true"); ensure "permissions" remains at top level and
"jobs" contains "sync-ledger" with the new concurrency key so the file validates
and behavior is unchanged.
Which Jira task belongs to this PR?
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)