Proposal: Wire for dependency injection#429
Draft
ondrej-fabry wants to merge 3 commits intoconfigfrom
Draft
Conversation
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new way to do dependency injection for the cn-infra application components (plugins). It uses github.com/google/wire library to generate code for connecting the components. This encourages explicit initialization at compile-time instead of using magic to resolve dependencies during runtime. Here's guide for the wire library: https://github.com/google/wire/blob/master/docs/guide.md
By switching to this method we could dramatically improve the Ligato code-base:
Init()/AfterInit()/Close()methodsagentandinfracould be removedoptions.gocould be removed